Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split LOOT API into its own repository #759

Closed
Ortham opened this issue Feb 5, 2017 · 3 comments
Closed

Split LOOT API into its own repository #759

Ortham opened this issue Feb 5, 2017 · 3 comments
Milestone

Comments

@Ortham
Copy link
Member

Ortham commented Feb 5, 2017

Following from #753, it would be good to split the LOOT API into its own repository, and leave this repository for the GUI application only. The GUI build would then handle the API like how loot-api-python handles it. Like the Python wrapper, it would probably be useful to give the GUI its own versioning.

@Ortham Ortham added this to the v0.11.0 milestone Feb 5, 2017
@Ortham
Copy link
Member Author

Ortham commented Feb 6, 2017

@Freso: For the API repository, do you think I should try to rewrite all the GUI bits out of history, or just have a commit deleting those files? I'm leaning towards the latter as there's not a clean split throughout history, so there'll be stuff left over, and the repo isn't very big anyway (~10 MB).

@Freso
Copy link
Member

Freso commented Feb 6, 2017

I think the most in-the-future-understandable approach is to make a commit cleaning out the GUI stuff. That will explain to anyone looking at the code in 5–10 years what happened—and if we ever decide to revert it, the two code bases will have common ancestor commits which makes for much easier merging. :)

The only downside that I can think of is 1) it makes the repository larger (if size is a big issue, you can clone a shallow copy for compiling etc.), 2) it makes it harder to tell exactly where/when the split happened when looking at the grand scheme of things (but OTOH, it also gives a more correct history, since the API was technically part of the other codebase before the "split").

@Ortham
Copy link
Member Author

Ortham commented Feb 11, 2017

Done as of 089cb4f. I've also created the issues relevant to the API over to the new repository.

@Ortham Ortham closed this as completed Feb 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants