Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UI for plugin groups #896

Closed
9 tasks done
Ortham opened this issue Feb 26, 2018 · 3 comments
Closed
9 tasks done

Add UI for plugin groups #896

Ortham opened this issue Feb 26, 2018 · 3 comments
Assignees

Comments

@Ortham
Copy link
Member

Ortham commented Feb 26, 2018

This is the UI side of loot/libloot#20. The following needs to be done:

  • Add display of a plugin's group to its sidebar entry. The group should be displayed like priority is, and the default group should be omitted to keep it easy to spot non-default values.
  • Add a group input to the metadata editor. It needs to be populated with the current value and be a dropdown selector containing the names of currently-defined groups, as only defined groups are valid values. Saving the metadata should also save the group value. If the saved value matches the masterlist value, it should be implicit in the userlist.
  • Add a new UI dialog/panel that allows users to define new groups and extend the after sets of existing groups (allowing the removal of entries added in the userlist but not those present in the masterlist).

Issues to fix:

  • Adding a new group doesn't clear the input, so it's possible to add the group multiple times.
  • Allow an Enter keypress to add a group when the input is focused.
  • Increase the size of edge arrows to make them more visible.
  • Improve position of edge arrows, they're currently too close to the source node.
  • Clamp zoom so it's not possible to zoom in unnecessarily far.
  • Increase the zoom sensitivity so it jumps less between zoom levels.
@Ortham Ortham self-assigned this Feb 26, 2018
@Ortham
Copy link
Member Author

Ortham commented Mar 25, 2018

As mentioned in the forum thread, I'd ideally like the group editor to be an editable visualisation of the group graph, like this but for now I've implemented it as a couple of lists for simplicity.

EDIT: Here's somthing mostly-functional I've hacked together using Cytoscape:

screenshot 17

@Ortham
Copy link
Member Author

Ortham commented Mar 26, 2018

Alternative layout using dagre is more logical but less efficiently uses the available space:

screenshot 18
screenshot 19

@Ortham
Copy link
Member Author

Ortham commented Apr 7, 2018

Closing this as it's implemented and merged as of c17c583. I don't expect anything more than tweaks to the functionality at this point.

@Ortham Ortham closed this as completed Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

1 participant