Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

not working (makes app to crach - test on genymotion android 9 and 6) #102

Closed
pcloudzaman opened this issue Jun 27, 2019 · 7 comments
Closed

Comments

@pcloudzaman
Copy link

pcloudzaman commented Jun 27, 2019

i've created a brand new app and this is my xml:
adding civ library causes app to crash


tesed on genymotion android 9 and android 6
<com.mikhaellopez.circularimageview.CircularImageView
android:layout_width="250dp"
android:layout_height="250dp"
android:src="@drawable/flash"
app:civ_border_color="#3f51b5"
app:civ_border_width="4dp"
app:civ_shadow="true"
app:civ_shadow_radius="10"
app:civ_shadow_color="#3f51b5"/>

@lopspower
Copy link
Owner

Can you send me more information about your crash ? What crash do you have ? Can you send the flash drawable ?

@pcloudzaman
Copy link
Author

here are the flash.png and flash.jpg
and for reproducing the problem, I just create a new android studio project (latest version of android studio, and latest version of sdk, min sdk 18, targetsdk29) and use genymotion android 9 and add dependency in gradle and the above code in main activity xml.
https://www.dropbox.com/s/sfny2oacp62hqis/flash.png?dl=1
https://www.dropbox.com/s/m6z13mk3l5f8rd3/flash.jpg?dl=1

@lopspower
Copy link
Owner

Thank you for you feedback @pcloudzaman
I try to find your problem with your last repository: https://github.com/pcloudzaman/MyApplication5

The problem is that the latest version of CircularImageView is in Kotlin and your project is in Java.
To solve the problem, you must add the kotlin-stdlib dependency in your project:

implementation "org.jetbrains.kotlin:kotlin-stdlib:1.3.40"

@pcloudzaman
Copy link
Author

thank you very very much for your help
and thank you again for this amazing library.

@lopspower
Copy link
Owner

Thank you for your feedback @pcloudzaman
I will try to correct the problem so that I don't need to add this dependency in the next version.

@pcloudzaman
Copy link
Author

thanks

@lopspower
Copy link
Owner

I publish a new version of this library with this fix:
https://github.com/lopspower/CircularImageView/releases/tag/4.0.1

implementation 'com.mikhaellopez:circularimageview:4.0.1'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants