Don't create a new shader in every call to onDraw().

[simonedstromsi]

Creating a new shader and bitmap in every call to onDraw (up to 60times / second) is very bad for performance.

Try creating the shader in onSizeChanged() to make sure your bitmap has the right size.

[samskiter]

👍 although onDraw would only be called up to 60times /seconds if you were animating the size of the view or something

[simonedstromsi]

Or if it's in a list that scrolls :)

[samskiter]

@simonedstromsi not as far as i'm aware - it will simply be snapshotted and moved, ondraw won't be called

[simonedstromsi]

Ok :) I wasn't aware of that.

[samskiter]

@lopspower this is still an issue isn't it. AFAICT this is still the case... can submit a PR if you like, normally it just requires overriding onSizeChanged

[lopspower]

Yes if you can, I want a PR :) (Please update your repos before that)

[samskiter]

Done :)