Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multiple coins strategy #35

Open
hippalectryon-0 opened this issue Apr 8, 2021 · 5 comments
Open

Add support for multiple coins strategy #35

hippalectryon-0 opened this issue Apr 8, 2021 · 5 comments
Labels
type:enhancement New feature or request warn:good first issue Good for newcomers warn:help wanted Extra attention is needed

Comments

@hippalectryon-0
Copy link

Right now the bot is tailored towards the default, one-coin strategy.

@lorcalhost lorcalhost added type:enhancement New feature or request warn:good first issue Good for newcomers warn:help wanted Extra attention is needed labels Apr 8, 2021
@lorcalhost
Copy link
Owner

Hi @hippalectryon-0 ,
would you mind sharing the list of incompatibilities you have found when using the multiple coins strategy?
It would really help me pinpoint the issues and fix them quicker :)

@hippalectryon-0
Copy link
Author

hippalectryon-0 commented Apr 8, 2021

@lorcalhost Sorry for not elaborating. After thinking over it a bit and talking in the BBot discord, it seems that the multiple coin strategy is still a bit in its infancy and may change in further updates, so it might not be worth it to implement it right away for the telegram bot.

Nevertheless, the main issue is that unlike the default strategy, the multiple coin strategy does not have a "current coin", all coins may be used. Therefore, actually, the "Current value" only shows the last traded coin and not the list of coins being traded, which would be the expected behavior.

@lorcalhost
Copy link
Owner

@hippalectryon-0 Thanks for elaborating,
so the incompatibility is only in the "Current value" feature so far?


I looked into the multiple coin strategy myself and couldn't really understand the behavior as it still is trading only one coin at a time.
I will try to understand it a bit better but as you said it still being in its infancy means it could change at any time.


Right now I'm a bit busy with life but this weekend I'll try setting priorities and see if implementing this feature at this stage makes sense.
Thanks for using the bot!

@hippalectryon-0
Copy link
Author

hippalectryon-0 commented Apr 8, 2021

so the incompatibility is only in the "Current value" feature so far?

Yes, as far as I know, although issue #38 might be related @lorcalhost

I looked into the multiple coin strategy myself and couldn't really understand the behavior as it still is trading only one coin at a time.

It trades one coin at a time if you start with only one coin, but if you start with several coins it will trade several.

Take your time, don't worry :) thanks for all your work ! I might try to submit a PR once I understand better the bot's code.

@556isback
Copy link

Any updates or future plan on this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement New feature or request warn:good first issue Good for newcomers warn:help wanted Extra attention is needed
Development

No branches or pull requests

3 participants