Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crash on unknown model #37

Closed
ghobson2013 opened this issue Oct 10, 2022 · 1 comment
Closed

crash on unknown model #37

ghobson2013 opened this issue Oct 10, 2022 · 1 comment
Labels
A: game area: game integration C: bug category: bug

Comments

@ghobson2013
Copy link
Contributor

ghobson2013 commented Oct 10, 2022

Hi there,

First of all thanks for this great tool...

While loading the media if the model is unknown currently i get a SIGSEV memory violation
in game.go lResolveNode function
A simple nill check avoids the problem and allows the LoadGame to complete.
see PR request.

Also i had a question around loading media from 2 different sources, minetest_game is one but mods is a different folder,
is there a way to pass more than 1 media path ?

Regards,
Gary

@weqqr
Copy link
Collaborator

weqqr commented Oct 10, 2022

Thanks for the report!

Game loading (and the mapper in general) is largely incomplete since the only game we tested was our own :)

Fetching media from different paths never crossed my mind, but should be fairly straightforward to implement. I created issue
#39 for that.

@weqqr weqqr added C: bug category: bug A: game area: game integration labels Oct 10, 2022
@weqqr weqqr closed this as completed in 1c4c728 Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: game area: game integration C: bug category: bug
Projects
None yet
Development

No branches or pull requests

2 participants