Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab issues #27

Closed
piernik opened this issue Dec 5, 2014 · 5 comments
Closed

Tab issues #27

piernik opened this issue Dec 5, 2014 · 5 comments
Labels

Comments

@piernik
Copy link
Contributor

piernik commented Dec 5, 2014

  1. When I use tab key and focus to Your select it doesn't open - I have to press down key to open - can You make it to open on focus?
  2. I can change option highlight with tab key - I think that options should have tabindex="-1"
  3. On blur with tab key options should close.
@piernik piernik changed the title Open options on focus Tab issues Dec 5, 2014
@lordfriend
Copy link
Owner

  1. vanilla select and bootstrap-select plugin also doesn't open when having focus on. I will keep the same behavior.
  2. Also, this is the behavior of Bootstrap-select. I just follow it. But You advise can be considered. tab on option may annoying sometimes.
  3. As the same as NO.2 question. This just following Bootstrap-select.

@lordfriend
Copy link
Owner

In ff, tab key will skip to next focusable element instead of changing options. So this is inconsistent feature crossing browsers.

@piernik
Copy link
Contributor Author

piernik commented Dec 5, 2014

Shame - Your script is independent - why to make copy of boostrap-select?
I think it should be fixed in bootstrap-select as well.

@lordfriend
Copy link
Owner

You may not know the history of this project.
Its previous major version is just a wrapper of Bootstrap-select. which depends on that plugin.
Current version is rewrite to achieve most of its features. with an angular way implement. not a copy.
But its goal don't change. it should provide an similar feature of Bootstrap-select for those migrate from the previous version.

@piernik
Copy link
Contributor Author

piernik commented Dec 5, 2014

I see. I think I should make changes on my own.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants