Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work with angular bootstrap. #4

Closed
pavlov99 opened this issue May 27, 2014 · 3 comments
Closed

Work with angular bootstrap. #4

pavlov99 opened this issue May 27, 2014 · 3 comments

Comments

@pavlov99
Copy link

Hello @lordfriend

First of all, thanks for good code! During implementation of nya-bootstrap-select to project I'm working on, I found the issue:

nya-bootstrap-select depends on bootstrap-select which depends on twitter bootstrap.js (it uses Dropdown). In the project we switched to angular ui bootstrap, which substitutes bootstrap.js, so bootstrap-select could not use its dropdown functionality. We solved this by copying the code from bootstrap.js. I could pull request this functionality, what do you think?

At the nya blog page http://nya.io/ it is written that nya-bootstrap-select will be updated. Could you share your plans? Do you want to turn it to something like way?

Thanks,
林林。

@lordfriend
Copy link
Owner

Bootstrap-select only need bootstrap.css and jquery as dependencies. bootstrap.js is not neccessary. I also use both bootstrap-select and angular-ui-bootstrap in my project. It works well.

The only problem currently can't solved is angular has already define <select> tag as a directive. this will cause many strange behavior when using ng-options. I hate hacking angularjs. So I decide to write this directive which only depends angularjs and contains most of the bootstrap-select features.

@pavlov99
Copy link
Author

Any help I could do?

@lordfriend
Copy link
Owner

Rewriting is not started yet. Any suggestion is welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants