Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lore-generate-new] add favicon to new projects #155

Closed
jchansen opened this issue Feb 10, 2017 · 1 comment
Closed

[lore-generate-new] add favicon to new projects #155

jchansen opened this issue Feb 10, 2017 · 1 comment

Comments

@jchansen
Copy link
Contributor

New projects don't include a favicon, which results in this console error the in the browser dev tools:

http://localhost:3000/favicon.ico
Failed to load resource: the server responded with a status of 404 (Not Found)

A favicon should be added to new projects as an example. Some discussion around how create-react-app chose to implement it can be found here, along with issues they found in the process:

facebook/create-react-app#69

@jchansen
Copy link
Contributor Author

jchansen commented Apr 4, 2017

This was resolved as part of #166, alongside the Webpack v2 upgrade, using the favicons-webpack-plugin .

@jchansen jchansen closed this as completed Apr 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant