Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carthage support #26

Closed
manucheri opened this issue Jan 18, 2018 · 4 comments
Closed

Carthage support #26

manucheri opened this issue Jan 18, 2018 · 4 comments

Comments

@manucheri
Copy link
Contributor

manucheri commented Jan 18, 2018

In addition to CocoaPods I think Carthage support would be nice to have.

I might have time to help implement this in the future, but submitting an issue now in case someone feels up to the task.

Carthage info: https://github.com/Carthage/Carthage

I think the only thing that needs to be changed is making the schemes for building the framework 'shared'.

Releases are already tagged according to SemVer, which Carthage will respect automatically, so that is already done.

@aanuza
Copy link

aanuza commented Jul 17, 2018

using https://github.com/aanuza/LGButton/tree/carthage_support

github "aanuza/LGButton" "carthage_support"

@LinusU
Copy link

LinusU commented Dec 17, 2018

@loregr would you accept a PR for this?

@loregr
Copy link
Owner

loregr commented Dec 17, 2018

@LinusU sure, PRs are more than welcome :)

@stale
Copy link

stale bot commented Feb 20, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs in 7 days. Thank you for your contributions.

@stale stale bot added the stale label Feb 20, 2019
@stale stale bot closed this as completed Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants