-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
process.EventEmitter is deprecated in Node.js v6.*.* #29
Comments
Upon further investigations, found that the issue is not from the monitor classes, but actually from the old version of socket.io used as a dependency (0.9.*). Using the latest version of socket.io (1.4.6 right now) takes away the deprecated warning, and the basic functionality appears to be working with the new version. However, more extensive tests would be needed to verify that all the functionality is working with the new socket.io version. Any thoughts? |
This package hasn't been maintained in years. If you're getting value from it and want to upgrade dependencies, issue a pull request. I'll do a quick check and publish to NPM. |
@lorenwest Thanks for the quick reply. And yes, we do see value in this package. I'm testing the updated dependencies now (upgraded socket.io to 1.4.6). Although the basic functionality works (such as the use of ProcessProbe) the unit tests are having issues. In 2 of the unit tests - RouterTest.js and MonitorTest.js - the test gets 'stuck' at a certain test case, as if the test.done() isn't getting called: RouterTest.js
gets stuck after that. MonitorTest.js
gets stuck after that. All other unit tests are passing. I'm still trying to figure out the cause of this issue. Thanks. |
I've encountered the same warning, Environment |
process.EventEmitter is deprecated in Node.js v6..
It is causing a deprecated warning when loading node-monitor,
DeprecationWarning: process.EventEmitter is deprecated. Use require('events') instead.
Tested on Node.js v6.1.0, on Windows.
The text was updated successfully, but these errors were encountered: