Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider verifying submarine address in reveal #13

Closed
lorenzb opened this issue Aug 15, 2018 · 2 comments
Closed

Consider verifying submarine address in reveal #13

lorenzb opened this issue Aug 15, 2018 · 2 comments

Comments

@lorenzb
Copy link
Owner

lorenzb commented Aug 15, 2018

This might allow us to get rid of revealDeposit.
@thegostep thegostep mentioned this issue Sep 22, 2018
Closed
@thegostep
Copy link
Collaborator

What is the message to pass to ecrecover?

@relyt29
Copy link
Collaborator

relyt29 commented Sep 27, 2018 •
edited
Loading

What is the message to pass to ecrecover?

Gonna need a little more context to understand what you're asking here, unless I already answered this on slack

Is the intent of this issue to check the (v,R,S) triple in the reveal function, and then to run ecrecover there to ensure that the submarine address matches?

@relyt29 relyt29 mentioned this issue Oct 18, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lorenzb @relyt29 @thegostep