ControllerFactoryFilter::getController returns false

[aydot]

ControllerFactoryFilter::getController returns false when trying to use controller method injection.
I see it returns false from here :
[https://github.com/lorenzo/piping-bag/blob/master/src/Routing/Filter/ControllerFactoryFilter.php#L93]
but I am calling from a controller, and I don't understand why it's returning false when there is definitely a controller.

[aydot]

Also, the Injecting Dependencies in Controllers example code you have doesn't work for me. When I use the Piping::get('Classname'), it works. but when i inject the dependency, and put the annotation, it doesn't.

[lorenzo]

I'll take a look at this soon.

[aydot]

Had a chance to look at this yet ?

[lorenzo]

I can confirm the bug...

[lorenzo]

@aydot due to some changes I made earlier for performance, I had to change the way the plugin is installed. Check the new instructions https://github.com/lorenzo/piping-bag#configuration

In particular, you need to change

DispatcherFactory::add('ControllerFactory');

With the following:

use PipingBag\Di\PipingBag;
DispatcherFactory::add(PipingBag::get('PipingBag\Routing\Filter\ControllerFactoryFilter'));

[aydot]

the controller action injection still doesn't work for me

[lorenzo]

Tell me what you did, it works for me fine

[lorenzo]

@aydot actually you are right, it does not work. I need to investigate further.

[aydot]

have an idea when you'd be able to look into this? quick question, will this work for a Controller constructor injection just like Laravel does?

[lorenzo]

Hey, I'm sorry about this issue. I'm currently sorting it out with Ray.Di creator, since I need a feature that is not currently supported in the library.

CakePHP already reserves the constructor of the controller, so adding more parameters to it will only feel awkward. Instead you can use use any other method to get your dependencies injected:

/**
 * @Inject
 */
public function postConstruct(Dep1 $dep, Dep2 $dep2 ....) {
}

I'll try to solve this issue as soon as possible. If you need any workaround please let me know. There are way to workaround this, but need some changes in Ray.Di to make this work in a generic way.

[aydot]

How do I write test for the dependencies? Will I have to swap out the instance in the container?
I tried this code here but didn't work.

$container = new Container;
$browser = $this->getMock('Ikimea\Browser\Browser');
(new Bind($container, 'Ikimea\Browser\Browser'))->toInstance($browser);

[lorenzo]

The best way is to create a new container with extra modules that you can use in the test. In general, this technique is used for integration testing and makes no much sense for unit testing since you should be passing the dependencies manually:

PipingBag::container($anotherInjectorInstance);

You can create the injector instance manually or by passing the result of calling PipingBag::create($allModulesNeededForTest)

[aydot]

How would you test a code like this?

<?php
namespace App\View\Cell;

use Cake\View\Cell;
use PipingBag\Di\PipingBag as Di;
use Ikimea\Browser\Browser;

class BrowserCompatibilityCell extends Cell
{
    protected $_validCellOptions = [];

    public function display()
    {
        $browser = Di::get('Ikimea\Browser\Browser');
        $this->set('browser', $browser->getBrowser().' '.$browser->getVersion());
    }
}

Since I can't inject it's dependency via the constructor

[lorenzo]

Closing this as it is working now