Cards manipulation #114
Merged
Cards manipulation #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uired. Some bugfixes applied.
LukeyQ1
reviewed
May 28, 2018
| } | ||
| } | ||
|
|
||
| exportToJupyter() { |
There was a problem hiding this comment.
This may need to be changed later in the newFeaturesUI branch to allow for exporting selected cards required for #108
LukeyQ1
reviewed
May 28, 2018
| new CardOutput('text/html', '<div id="66f3f87d-6ec3-46a5-81b7-0d78b189a25f" style="height: 525px; width: 100%;" class="plotly-graph-div"></div><script type="text/javascript">require(["plotly"], function(Plotly) { window.PLOTLYENV=window.PLOTLYENV || {};window.PLOTLYENV.BASE_URL="https://plot.ly";Plotly.newPlot("66f3f87d-6ec3-46a5-81b7-0d78b189a25f", [{"x": [1, 2, 3], "y": [3, 1, 6]}], {}, {"showLink": true, "linkText": "Export to plot.ly"})});</script>'), | ||
| ], {}, 'python3') | ||
| ]; | ||
| cards: Card[] = []; |
There was a problem hiding this comment.
Maybe at some point we can have s starter card that explains functions, a "Tutorial Card"
LukeyQ1
reviewed
May 28, 2018
| @@ -15,7 +15,7 @@ | |||
| <button class="react toolbar-icon right"> | |||
| <i class="ms-Icon ms-Icon--MiniExpand" aria-label="Open in Browser"></i> | |||
| </button> | |||
| <button class="react toolbar-icon right" (click)="card.collapsed = !card.collapsed; editingTitle = false"> | |||
| <button class="react toolbar-icon right" (click)="card.collapsed = !card.collapsed; editingTitle = false; collapseCard(card.collapsed)"> | |||
There was a problem hiding this comment.
It would be nice to put all these functions inside the collapseCard function.
<button class="react toolbar-icon right" (click)="collapseCard()">collapseCard(value: boolean){
card.collapsed = !card.collapsed;
editingTitle = false;
this.onCollapseCard.emit({card.collapsed});
}Although this would be a lot of changes and would cause a lot more merge conflicts with other branches like newFeatureUI so maybe should be done later in that branch?
LukeyQ1
reviewed
May 28, 2018
| @@ -57,4 +62,23 @@ export class CardComponent { | |||
| this.onDelete.emit(); | |||
| } | |||
|
|
|||
| collapseOutput(value: boolean){ | |||
LukeyQ1
reviewed
May 28, 2018
lorenzo2897
requested changes
May 28, 2018
LukeyQ1
approved these changes
May 29, 2018
lorenzo2897
approved these changes
May 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cards are now synchronised between the backend and frontend.
Custom markdown cards are fully supported and are exportable.
Fixes #2, Fixes #5, Fixes #25, Fixes #95, Fixes #105