Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are there any plans to move towards Bootstrap 3? #35

Closed
DrAlexMV opened this issue Aug 5, 2013 · 2 comments
Closed

Are there any plans to move towards Bootstrap 3? #35

DrAlexMV opened this issue Aug 5, 2013 · 2 comments

Comments

@DrAlexMV
Copy link

DrAlexMV commented Aug 5, 2013

Since Bootstrap 3 is not backwards compatible, I was wondering what the plans are to migrate into Bootstrap 3. I can start contributing to migrating the app to B3 if you create a new branch for it.

@lorenzofox3
Copy link
Owner

Since, Smart-Table has nothing to do with Bootstrap, there no plan to "migrate" to Bootstrap 3. The only thing that may be impacted is the pagination directive taken from the project angular-ui.bootstrap; but again it should not prevent you of using a different stylesheet for this particular directive (that is actully part of the philosophy of their project: not relying on third party).

By the way, if you want to contribute, I don't have to create a new branch, you can just clone the repository and submit as a pull request I can merge with master branch or any other branch.

Laurent

@DrAlexMV
Copy link
Author

DrAlexMV commented Aug 5, 2013

Well, for the pagination one, the fix is simple to make it work with B3. Problem is, it won't work with B2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants