Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support --root for more hooks #438

Merged
merged 10 commits into from Sep 29, 2022

Conversation

TNonet
Copy link
Contributor

@TNonet TNonet commented Aug 10, 2022

See: #432

I seem to get a docopt issue when specifying an option without any arguments. See: #429 (comment).
Therefore, I added <_ignored>... arguments as a workaround. I bet there is a better solution, but I wanted to get this initial commit out quickly.

I am unsure what is wrong with my new roxygenize tests.

@TNonet
Copy link
Contributor Author

TNonet commented Aug 10, 2022

@lorenzwalthert, I can't seem to assign reviewers.

@lorenzwalthert lorenzwalthert changed the title Tnonet/issue 429 Support --root for more hooks Aug 10, 2022
@lorenzwalthert
Copy link
Owner

lorenzwalthert commented Aug 13, 2022

ok @TNonet I think I found the problem. Quite annoying combination of here::here() as the default value for root (after setwd()`, it's not updated) and some weird {git2r} behaviour. Anyways, let's see if checks pass. Do you want to update the docs in the meantime? I.e. NEWS.md and the vignette on available hooks.

NEWS.md Outdated Show resolved Hide resolved
@lorenzwalthert lorenzwalthert merged commit b89a478 into lorenzwalthert:main Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants