Revised add spaces

[kcphila]

Rewrote the PR based on discussion to provide a global wrapper around all docopt calls. Also added some tests to verify that calls to docopt work both when args are preprocessed (exclusively in style-file) and not (created tests for parsable-R for this example).

[lorenzwalthert]

Thanks for the effort to make a new PR @kcphila, see the comments I made. To fix R cmd check issues, please roxygenise and run the pre-commit hooks that should fix some formatting problems. Pre-commit.ci failed because a binary was not yet available for {curl} from the PPM as the roxygenise hook for some reason depends on {curl} recursively.

[lorenzwalthert]

@kcphila please did you forget to install the pre-commit hooks? precommit::use_precommit(). Because roxygen did not run.you can also run roxygen manually. Also, pre-commit hooks succeeded, so maybe caching fools us for new Rd files… needs separate investigation.

[lorenzwalthert]

Can you fix these style issues and re-document (or let pre-commit.CI do it)?

[kcphila]

Can you fix these style issues and re-document (or let pre-commit.CI do it)?

Hi @lorenzwalthert, looks like you committed the two minor revisions from this morning. Are there any outstanding issues remaining?

[lorenzwalthert]

Only that I realised all hook script helper have

#' This function is only exported for use in hook scripts, but it's not intended
#' to be called by the end-user directly.

in their docs. Can you add that? And that the roxygen hook had a regression described in #517, but that’s unrelated to your PR.

[lorenzwalthert]

Then we can merge. Sorry I can’t help, away without labtop

[lorenzwalthert]

Great. @kcphila as a final test before we merge this, you can already use this in your repo. In your pre-commit config, set the rev tag to the commit 44ed0e2 instead of the latest tag or branch you have there. Then, try to commit something. Pre-commit will first install this very revision and then run the checks and then commit. So I suggest you test this with a file that previously did not work because it has spaces in the file name. If everything works, please confirm that here and I will merge the PR. Ok?

[kcphila]

If everything works, please confirm that here and I will merge the PR. Ok?

Hi @lorenzwalthert, success! I verified it crashing with the 0.3.2 and then updated the yaml config and it styled successfully. Just for sanity I also did the same for a already correctly styled file with artificial spaces in it.

[lorenzwalthert]

Thanks @kcphila, glad we got this right in the second iteration. I will release a new hook version soon (will be a new git tag), as for now, your team can just use the hash you used for testing.