Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip when no changes to source code files? #117

Open
IndrajeetPatil opened this issue Sep 28, 2022 · 4 comments
Open

Skip when no changes to source code files? #117

IndrajeetPatil opened this issue Sep 28, 2022 · 4 comments

Comments

@IndrajeetPatil
Copy link

Given how expensive this workflow is, do you think {touchstone} should skip benchmarking when there is no change to any files containing source code?

E.g., here only a YAML file was changed, but we are still benchmarking ever commit in this PR, which is unnecessary since this file doesn't contain any source code and any change to it will have no effect on performance.

@lorenzwalthert
Copy link
Owner

Maybe source files are too restrictive. But we could restrict it to source files + DESCRIPTION + touchstone/*? I.e. if dependencies change, we don't want to skip.

@IndrajeetPatil
Copy link
Author

Yes, that sounds good to me!

Thanks for being open to the idea.

@assignUser
Copy link
Collaborator

You can easily implement this change directly in your workflow file by adding the paths node:

on: 
  pull_request:
    paths:
      # Filter by dir
     - "r/**"
     - "src/**"
     - "touchstone/**"
     # or file type
     - "*.r"
     # or specific files
     - ".github/workflows/touchstone-*.yaml"
     - DESCRIPTION

I think running without filter should be the default but we should probably add some documentation about this functionality 👍

@lorenzwalthert
Copy link
Owner

Looks good. Should we add this to the template?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants