Cli attempt #2
Open
Cli attempt #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k are printed within the same buffer. Changed the sizing method, taking the best of manual formatting and automatic formatting. `traceback` doesn't use cpythons current format for determining the pathname of an object, but it does format most of the messages correct. Small limitation with 3.10 in mind, the suggestions added by 3.10's error handling update doesn't cross over to python's traceback. Namely the suggestion system added is done completely in python, negating the ability to grab it. The result of STDERR could be captured to parse that first, ensuring that it's always the correct length.
…age, `python -m __main__.py test.py` or by installing it through pip with the local sdist.
A console script was added to the setup.py and can be used as `assistant test.py`.
Notable limitation:
Using `input("prompt")` buffers the output of the prompt until user input has been given. This likely extends to other areas of user interaction as well. This also seemingly varies from terminal to terminal, PyCharms builtin terminal ignores this limitation and functions fine. Windows powershell and cmd both buffer the input, alongside the buffered input, both terminals also pass the prompt of the input to stderr.
|
I looked at the code and the main looks a bit too hacky for me. But you laid the groundwork. I've sent you a PR on the branch so that you can see what I've done. As for CPython injecting text in the error messages, I haven't updated to python3.10 yet, If you could create an issue I could look into it once I have updated. |
|
If you merge it I can then merge this PR with the changes you made to setup.py |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I took a crack at making a Cli tool, as I noted in the commit, it's got a pretty significant limitation at the moment.
I figured I'd let you take a glance and determine if you could spot any other methods of going about it.
While doing that I noticed that the method of getting the length was wrong in some edge cases. Those should be dealt with however, there is also an issue of CPython injecting content into the traceback after it's been pulled into the lower level environment. The new 3.10 suggestions don't appear in exceptions created by the traceback module at the moment, currently it seems the only way to match the sizing is the capture the output of stderr and parse that, but as always, that's a bit iffy.
The traceback module only creates up to
not defined, everything past that is generated after the exception has been fired off.