Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browserify require #126

Closed
baptooo opened this issue Nov 23, 2015 · 2 comments
Closed

Browserify require #126

baptooo opened this issue Nov 23, 2015 · 2 comments

Comments

@baptooo
Copy link

baptooo commented Nov 23, 2015

Hello @meandmax, I have noticed an issue when importing the library on browserify.

As the "main" property in package.json refers to "dist/lory.js", there is a wrapper on the library apparently and the module imported looks like this,

{
    __esModule: true,
    lory: function() { ... }
}

I moved back to v1.2.6 which works fine actually.

Thank you very much !

@meandmax
Copy link
Collaborator

This could be actually a bug caused by the update to babel6 .. Have u tried to import the module like the following:

import {lory} from 'lory.js'

Sorry for this breaking change! That was not my intend.

Max

@meandmax
Copy link
Collaborator

This issue will be fixed by

#148

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants