Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken zoom because of an undefined attribute #108

Closed
Lattay opened this issue Dec 22, 2022 · 2 comments · Fixed by #109
Closed

Broken zoom because of an undefined attribute #108

Lattay opened this issue Dec 22, 2022 · 2 comments · Fixed by #109

Comments

@Lattay
Copy link
Contributor

Lattay commented Dec 22, 2022

Describe the bug
When trying to zoom with the mouse wheel, an exception is raised in the check for a menu item (or something ?)

path is undefined.

To Reproduce
Steps to reproduce the behavior:

  1. Open the editor
  2. Open the developer console of the browser
  3. Scroll with the mouse wheel on the canvas
  4. See error TypeError: mouseEvent.path is undefined

Expected behavior
Zooming (also I am not sure what is the point of view on zoom right now, seeing #103)

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: Linux
  • Browser: Firefox
  • Version: 108

Additional context
The mouseEvent object should be a WheelEvent.
There is no such path attribute documented, I don't know where it is supposed to come from.

Note that I tried to comment this line (and the one below) in a development instance of the app (on current master, namely 5d55425) and the zoom worked as expected.

@unsettledgames
Copy link
Collaborator

Looks like path is not supported by FireFox. Let me know if you want to fix the bug on your own or wait for us (unfortunately there aren't many active contributors, even though they're more than welcome). In case you want to work on the bug these links might be useful:
https://stackoverflow.com/questions/39245488/event-path-is-undefined-running-in-firefox
https://developer.mozilla.org/en-US/docs/Web/API/Event/composedPath

@Lattay
Copy link
Contributor Author

Lattay commented Dec 22, 2022

No problem, I'll fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants