Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dockerfile (and maybe pipelines for tests?) #93

Closed
blueprismo opened this issue Sep 13, 2022 · 2 comments
Closed

Add Dockerfile (and maybe pipelines for tests?) #93

blueprismo opened this issue Sep 13, 2022 · 2 comments

Comments

@blueprismo
Copy link
Contributor

Is your feature request related to a problem? Please describe.
No, I just love Docker :) 🐳

Describe the solution you'd like
Dependencies are minimal in this project, but why not having it dockerized and that way it will always work everywhere [with the same cpu-arch]? (and there will be no mismatches between versions (npm, node, OS running it...)).

I can contribute with a Dockerfile and some initial github actions workflow.

Additional context
None 💯

@skeddles
Copy link
Collaborator

If the docker file is completely optional, you are welcome to submit a pull request that adds one. I don't think it's really necessary since i think most of our modules are pure js, which should run the same on every platform. But if it helps some people without forcing them, then I'm for it.

This was referenced Oct 6, 2022
@unsettledgames
Copy link
Collaborator

Implemented in #99

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants