Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Savegame slots over 64 are unusable #1395

Closed
walkawayy opened this issue Jun 30, 2024 · 0 comments · Fixed by #1397
Closed

Savegame slots over 64 are unusable #1395

walkawayy opened this issue Jun 30, 2024 · 0 comments · Fixed by #1397
Assignees
Labels
Priority: medium Default priority – important, but not necessitating immediate action. TR1X bug A bug with TR1X
Milestone

Comments

@walkawayy
Copy link
Collaborator

Investigated by Lahm:

So the limit is 64 slots, and it's because of this 
int32_t gf_param = gf_option & ((1 << 6) - 1);
e.g. stemming from return GF_START_SAVED_GAME | g_GameInfo.current_save_slot in the inventory
https://github.com/LostArtefacts/TR1X/blob/develop/src/game/shell.c#L187

Hit 65, and it loops back to slot 1.
@walkawayy walkawayy added TR1X bug A bug with TR1X Priority: medium Default priority – important, but not necessitating immediate action. labels Jun 30, 2024
@walkawayy walkawayy added this to the 4.2 milestone Jun 30, 2024
@walkawayy walkawayy self-assigned this Jun 30, 2024
walkawayy added a commit to walkawayy/TR1X that referenced this issue Jul 2, 2024
walkawayy added a commit to walkawayy/TR1X that referenced this issue Jul 2, 2024
walkawayy added a commit to walkawayy/TR1X that referenced this issue Jul 2, 2024
@rr- rr- closed this as completed in #1397 Jul 2, 2024
@rr- rr- closed this as completed in 0a7984f Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: medium Default priority – important, but not necessitating immediate action. TR1X bug A bug with TR1X
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant