Sourcery refactored main branch #4

sourcery-ai · 2021-06-05T13:44:06Z

Branch main refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Review changes via command line

To manually merge these changes, make sure you're on the main branch, then run:

git fetch origin sourcery/main
git merge --ff-only FETCH_HEAD
git reset HEAD^

Help us improve this pull request!

sourcery-ai · 2021-06-18T05:01:37Z

anibot/__init__.py

-HELP_DICT = dict()
+HELP_DICT = {}


Lines 17-87 refactored with the following changes:

Replace dict() with {} (dict-literal)

sourcery-ai · 2021-06-18T05:01:37Z

anibot/plugins/anilist.py

-        if not len(query)==2:
+        if len(query) != 2:


Function flex_cmd refactored with the following changes:

Simplify logical expression using De Morgan identities (de-morgan)

sourcery-ai · 2021-06-18T05:01:37Z

anibot/plugins/anilist.py

-        if spoiler==False:
+        if not spoiler:


Function additional_info_btn refactored with the following changes:

Simplify comparison to boolean (simplify-boolean-comparison)

sourcery-ai · 2021-06-18T05:01:37Z

anibot/plugins/anilist.py

-        if result[0]==False:
-            await cq.answer("No Data Available!!!")
-            return
+    if result[0]==False:
+        await cq.answer("No Data Available!!!")
+        return


Function featured_in_btn refactored with the following changes:

Hoist conditional out of nested conditional (hoist-if-from-if)

sourcery-ai · 2021-06-18T05:01:37Z

anibot/plugins/bot.py

-    if find_gc==None:
+    if find_gc is None:


Function list_disabled refactored with the following changes:

Use x is None rather than x == None (none-compare)

sourcery-ai · 2021-06-18T05:01:38Z

anibot/utils/data_parser.py

-    if auth is True:
+    if auth:


Function get_anime refactored with the following changes:

Merge duplicate blocks in conditional (merge-duplicate-blocks)

Simplify comparison to boolean (simplify-boolean-comparison)

Simplify sequence comparison (simplify-len-comparison)

sourcery-ai · 2021-06-18T05:01:38Z

anibot/utils/data_parser.py

-    if auth is True:
+    if auth:


Function get_anilist refactored with the following changes:

Merge duplicate blocks in conditional (merge-duplicate-blocks)

Simplify comparison to boolean (simplify-boolean-comparison)

Simplify sequence comparison (simplify-len-comparison)

sourcery-ai · 2021-06-18T05:01:39Z

anibot/utils/data_parser.py

-    if auth is True:
+    if auth:


Function get_manga refactored with the following changes:

Simplify comparison to boolean (simplify-boolean-comparison)

sourcery-ai · 2021-06-18T05:01:39Z

anibot/utils/data_parser.py

-    if auth is True:
+    if auth:


Function get_airing refactored with the following changes:

Simplify comparison to boolean (simplify-boolean-comparison)

sourcery-ai · 2021-06-18T05:01:39Z

anibot/utils/data_parser.py

-    k = await return_json_senpai(query=query, vars=vars_, auth=False if "user" in req else True, user=int(user))
+    k = await return_json_senpai(
+        query=query, vars=vars_, auth="user" not in req, user=int(user)
+    )
+


Function get_user refactored with the following changes:

Simplify boolean if expression (boolean-if-exp-identity)

Simplify logical expression using De Morgan identities (de-morgan)

sourcery-ai · 2021-06-18T05:01:41Z

anibot/utils/data_parser.py

-    out = []
-    for i in data:
-        out.append(f"{i['index']}. `{i['name']}`\n")
+    out = [f"{i['index']}. `{i['name']}`\n" for i in data]


Function get_wo refactored with the following changes:

Convert for loop into list comprehension (list-comprehension)

sourcery-ai · 2021-06-18T05:01:41Z

anibot/utils/data_parser.py

-    ret = {}
    keys = list(index.keys())
-    for i in range(len(keys)):
-        if query.lower() in keys[i].lower():
-            ret[keys[i]] = index[keys[i]]
-    return ret
+    return {
+        keys[i]: index[keys[i]]
+        for i in range(len(keys))
+        if query.lower() in keys[i].lower()
+    }


Function search_filler refactored with the following changes:

Convert for loop into dictionary comprehension (dict-comprehension)

Inline variable that is immediately returned (inline-immediately-returned-variable)

sourcery-ai · 2021-06-18T05:01:41Z

anibot/utils/data_parser.py

-        total_ep = []
        mix_ep = None
        filler_ep = None
        ac_ep = None
-        for tol in ttl_ep:
-            total_ep.append(tol.text)
+        total_ep = [tol.text for tol in ttl_ep]


Function parse_filler refactored with the following changes:

Convert for loop into list comprehension (list-comprehension)

sourcery-ai · 2021-06-18T05:01:41Z

anibot/utils/helper.py

-    if auth == False:
+    if not auth:
        url = "https://graphql.anilist.co"
-        response = requests.post(url, json={"query": query, "variables": vars}).json()
+        return requests.post(url, json={"query": query, "variables": vars}).json()


Function return_json_senpai refactored with the following changes:

Simplify comparison to boolean (simplify-boolean-comparison)

Lift return into if (lift-return-into-if)

sourcery-ai · 2021-06-18T05:01:42Z

anibot/utils/helper.py

-    th = "st" if x == "1" else "nd" if x == "2" else "rd" if x == "3" else "th"
-    return th
+    return "st" if x == "1" else "nd" if x == "2" else "rd" if x == "3" else "th"


Function pos_no refactored with the following changes:

Inline variable that is immediately returned (inline-immediately-returned-variable)

sourcery-ai · 2021-06-18T05:01:42Z

anibot/utils/helper.py

-        if result[0]!=0 and result[0]!=6:
+        if result[0] not in [0, 6]:


Function get_btns refactored with the following changes:

Replace multiple comparisons of same variable with in operator (merge-comparisons)

Simplify comparison to boolean (simplify-boolean-comparison)

Merge else clause's nested if statement into elif (merge-else-if-into-elif)

sourcery-ai · 2021-06-18T05:01:50Z

Sourcery Code Quality Report

✅ Merging this PR will increase code quality in the affected files by 0.92%.

Quality metrics	Before	After	Change
Complexity	16.45 🙂	15.41 🙂	-1.04 👍
Method Length	165.20 😞	163.96 😞	-1.24 👍
Working memory	15.40 ⛔	15.23 ⛔	-0.17 👍
Quality	40.00% 😞	40.92% 😞	0.92% 👍

Other metrics	Before	After	Change
Lines	2968	2961	-7

Changed files	Quality Before	Quality After	Quality Change
anibot/init.py	64.56% 🙂	64.67% 🙂	0.11% 👍
anibot/plugins/anilist.py	43.55% 😞	43.64% 😞	0.09% 👍
anibot/plugins/bot.py	34.29% 😞	34.32% 😞	0.03% 👍
anibot/plugins/livechartme.py	58.63% 🙂	58.63% 🙂	0.00%
anibot/plugins/tracemoepy.py	29.89% 😞	29.90% 😞	0.01% 👍
anibot/plugins/watch.py	57.30% 🙂	55.92% 🙂	-1.38% 👎
anibot/utils/data_parser.py	33.62% 😞	36.06% 😞	2.44% 👍
anibot/utils/helper.py	54.60% 🙂	55.11% 🙂	0.51% 👍

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
anibot/plugins/bot.py	en_dis__able_cmd	63 ⛔	383 ⛔	22 ⛔	6.09% ⛔	Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
anibot/utils/data_parser.py	get_anilist	36 ⛔	649 ⛔	28 ⛔	8.20% ⛔	Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
anibot/utils/data_parser.py	get_anime	36 ⛔	639 ⛔	27 ⛔	8.42% ⛔	Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
anibot/plugins/anilist.py	update_anilist_btn	57 ⛔	500 ⛔	16 ⛔	10.01% ⛔	Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
anibot/utils/helper.py	get_btns	32 😞	696 ⛔	18 ⛔	14.14% ⛔	Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

⭐ excellent
🙂 good
😞 poor
⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

sourcery-ai bot requested a review from lostb053 June 5, 2021 13:44

sourcery-ai bot force-pushed the sourcery/main branch from 15ed08b to ffcfb60 Compare June 5, 2021 13:54

'Refactored by Sourcery'

be4bda5

sourcery-ai bot force-pushed the sourcery/main branch from ffcfb60 to be4bda5 Compare June 18, 2021 05:01

sourcery-ai bot commented Jun 18, 2021

View reviewed changes

lostb053 closed this Jan 11, 2022

lostb053 deleted the sourcery/main branch January 11, 2022 05:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sourcery refactored main branch #4

Sourcery refactored main branch #4

sourcery-ai bot commented Jun 5, 2021 •

edited

sourcery-ai bot Jun 18, 2021

sourcery-ai bot Jun 18, 2021

sourcery-ai bot Jun 18, 2021

sourcery-ai bot Jun 18, 2021

sourcery-ai bot Jun 18, 2021

sourcery-ai bot Jun 18, 2021

sourcery-ai bot Jun 18, 2021

sourcery-ai bot Jun 18, 2021

sourcery-ai bot Jun 18, 2021

sourcery-ai bot Jun 18, 2021

sourcery-ai bot Jun 18, 2021

sourcery-ai bot Jun 18, 2021

sourcery-ai bot Jun 18, 2021

sourcery-ai bot Jun 18, 2021

sourcery-ai bot Jun 18, 2021

sourcery-ai bot Jun 18, 2021

sourcery-ai bot commented Jun 18, 2021

		if result[0]!=0 and result[0]!=6:
		if result[0] not in [0, 6]:

		HELP_DICT = dict()
		HELP_DICT = {}

Sourcery refactored main branch #4

Sourcery refactored main branch #4

Conversation

sourcery-ai bot commented Jun 5, 2021 • edited

sourcery-ai bot Jun 18, 2021

Choose a reason for hiding this comment

sourcery-ai bot Jun 18, 2021

Choose a reason for hiding this comment

sourcery-ai bot Jun 18, 2021

Choose a reason for hiding this comment

sourcery-ai bot Jun 18, 2021

Choose a reason for hiding this comment

sourcery-ai bot Jun 18, 2021

Choose a reason for hiding this comment

sourcery-ai bot Jun 18, 2021

Choose a reason for hiding this comment

sourcery-ai bot Jun 18, 2021

Choose a reason for hiding this comment

sourcery-ai bot Jun 18, 2021

Choose a reason for hiding this comment

sourcery-ai bot Jun 18, 2021

Choose a reason for hiding this comment

sourcery-ai bot Jun 18, 2021

Choose a reason for hiding this comment

sourcery-ai bot Jun 18, 2021

Choose a reason for hiding this comment

sourcery-ai bot Jun 18, 2021

Choose a reason for hiding this comment

sourcery-ai bot Jun 18, 2021

Choose a reason for hiding this comment

sourcery-ai bot Jun 18, 2021

Choose a reason for hiding this comment

sourcery-ai bot Jun 18, 2021

Choose a reason for hiding this comment

sourcery-ai bot Jun 18, 2021

Choose a reason for hiding this comment

sourcery-ai bot commented Jun 18, 2021

Sourcery Code Quality Report

Legend and Explanation

sourcery-ai bot commented Jun 5, 2021 •

edited