Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make API consistent #2

Open
astagi opened this issue Oct 11, 2019 · 1 comment
Open

Make API consistent #2

astagi opened this issue Oct 11, 2019 · 1 comment
Assignees
Labels
help wanted Extra attention is needed

Comments

@astagi
Copy link
Member

astagi commented Oct 11, 2019

Try to make no differences between properties and objects

@edoaxyz
Copy link
Member

edoaxyz commented Oct 15, 2019

Unfortunately the rendundancy happen only in the Product's categories and tags. Other properties that are linked to other objects have some differences between them. An example are Product's attributes, which can be referenced to a Product Attribute object, but can be also a new one created and available only for that Product. Another example is related to the Orders: they contains the informations about the ordered Product but if this last one will be updated, the one in Order won't, so there would be some discrepancy. I would think to add some methods to these "special" properties (eg. Product Attributes) in order to link them to the actual objects, if they exist. Check this

@edoaxyz edoaxyz added the help wanted Extra attention is needed label Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants