Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build crashing on React native macos #1018

Closed
HunainHumail opened this issue May 1, 2023 · 5 comments · Fixed by #1031
Closed

Build crashing on React native macos #1018

HunainHumail opened this issue May 1, 2023 · 5 comments · Fixed by #1031

Comments

@HunainHumail
Copy link

Description

I have installed react-native-macos in my project. Android and IOS are working fine with react-native-lotte. But when i am trying to build the macos project, the build is crashing.

[Description of the bug]
The following build commands failed:
SwiftEmitModule normal arm64 Emitting\ module\ for\ lottie_react_native (in target 'lottie-react-native-macOS' from project 'Pods')
(1 failure)

Also when I see my XCODE, getting this error Cannot find type 'UITraitCollection' in scope

Steps to Reproduce

react-native run-macos

Expected behavior: [What you expected to happen]
App should work as it is working for android and ios
Actual behavior: [What actually happened]
App is crashing
Screenshot 2023-05-01 at 3 14 17 PM

Versions

react native: 0.71
react native macos: 0.71

You can get this information from executing npm version.

@matinzd
Copy link
Collaborator

matinzd commented May 2, 2023

What version of lottie are you using?

@HunainHumail
Copy link
Author

HunainHumail commented May 2, 2023

@matinzd

What version of lottie are you using?

"lottie-react-native": "^5.1.5",
"react": "18.2.0",
"react-native": "0.71.7",
"react-native-macos": "^0.71.0-0",

@Saadnajmi
Copy link

React Native macOS maintainer here, if we ifdef out the iOS block for macOS, are there any other issues? I took a quick look at the code and it seems to be implemented cross platform

@matinzd
Copy link
Collaborator

matinzd commented May 25, 2023

Do you think this change will fix this issue?

https://github.com/lottie-react-native/lottie-react-native/compare/fix/react_native_macos_build

@Saadnajmi

@matinzd
Copy link
Collaborator

matinzd commented Jun 23, 2023

Let me know if this has fixed the issue in rc7. @HunainHumail

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants