New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nested params #71
Nested params #71
Conversation
Changes Unknown when pulling 8a1f5b3 on stevehodgkiss:nested_attributes into * on lotus:master*. |
Changes Unknown when pulling 76cae8a on stevehodgkiss:nested_attributes into * on lotus:master*. |
Changes Unknown when pulling 76cae8a on stevehodgkiss:nested_attributes into * on lotus:master*. |
@stevehodgkiss Thanks for this PR. As far I've seen, it looks good. Can you please add an integration test by covering the case reported by #70 ? Thank you. |
Changes Unknown when pulling 1d27658 on stevehodgkiss:nested_attributes into * on lotus:master*. |
@stevehodgkiss looks great 👍 |
Changes Unknown when pulling edbea42 on stevehodgkiss:nested_attributes into * on lotus:master*. |
@stevehodgkiss @joneslee85 👍 Steve, I know that this depends on hanami/validations#46. Maybe it's better to focus on that one first. |
Changes Unknown when pulling 6c6ba3a on stevehodgkiss:nested_attributes into * on lotus:master*. |
6c6ba3a
to
6daec19
Compare
@stevehodgkiss Thank you! ✨ 👍 |
@stevehodgkiss is this likely to be merged soon? :D |
@stevehodgkiss I've merged this. Thank you! ✨ 👍 ✨ |
Continuing on from the work to add nested validations in Lotus Validations. This PR aims to finish off the necessary changes to support that here, and also address #70.
The gemspec needed updating to get the validations code with nested attributes, but maybe it's the '0.2.x' branch that needs updating instead though.
(please don't merge yet)