Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested params #71

Merged
merged 9 commits into from Jan 28, 2015
Merged

Nested params #71

merged 9 commits into from Jan 28, 2015

Conversation

stevehodgkiss
Copy link
Contributor

Continuing on from the work to add nested validations in Lotus Validations. This PR aims to finish off the necessary changes to support that here, and also address #70.

The gemspec needed updating to get the validations code with nested attributes, but maybe it's the '0.2.x' branch that needs updating instead though.

(please don't merge yet)

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 8a1f5b3 on stevehodgkiss:nested_attributes into * on lotus:master*.

@stevehodgkiss stevehodgkiss changed the title Nested attributes Nested params Jan 13, 2015
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 76cae8a on stevehodgkiss:nested_attributes into * on lotus:master*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 76cae8a on stevehodgkiss:nested_attributes into * on lotus:master*.

@jodosha
Copy link
Member

jodosha commented Jan 14, 2015

@stevehodgkiss Thanks for this PR.

As far I've seen, it looks good. Can you please add an integration test by covering the case reported by #70 ? Thank you.

@jodosha jodosha self-assigned this Jan 14, 2015
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 1d27658 on stevehodgkiss:nested_attributes into * on lotus:master*.

@runlevel5
Copy link
Member

@stevehodgkiss looks great 👍

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling edbea42 on stevehodgkiss:nested_attributes into * on lotus:master*.

@runlevel5
Copy link
Member

@stevehodgkiss 👍

@jodosha
Copy link
Member

jodosha commented Jan 19, 2015

@stevehodgkiss @joneslee85 👍

Steve, I know that this depends on hanami/validations#46. Maybe it's better to focus on that one first.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 6c6ba3a on stevehodgkiss:nested_attributes into * on lotus:master*.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.0%) to 99.08% when pulling 6daec19 on stevehodgkiss:nested_attributes into 0893ab5 on lotus:master.

@jodosha
Copy link
Member

jodosha commented Jan 24, 2015

@stevehodgkiss Thank you! ✨ 👍

@jodosha jodosha added this to the v0.3.2 milestone Jan 24, 2015
@Emily
Copy link

Emily commented Jan 27, 2015

@stevehodgkiss is this likely to be merged soon? :D

@jodosha jodosha merged commit 6daec19 into hanami:master Jan 28, 2015
jodosha added a commit that referenced this pull request Jan 28, 2015
@jodosha
Copy link
Member

jodosha commented Jan 28, 2015

@stevehodgkiss I've merged this. Thank you! ✨ 👍 ✨

@jodosha jodosha deleted the nested_attributes branch January 28, 2015 07:57
@jodosha jodosha mentioned this pull request Jan 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants