Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force empty message when use redirect_to #97

Closed
wants to merge 1 commit into from
Closed

Force empty message when use redirect_to #97

wants to merge 1 commit into from

Conversation

AlfonsoUceda
Copy link
Contributor

complete #94

@jodosha
Copy link
Member

jodosha commented Mar 15, 2015

@AlfonsoUceda Thank you for this extra PR 👍

May I ask you to verify two things with Rack::Lint?

  1. Does it complains if we send an empty string?
  2. What happens if we set the body as nil?

Thank you 😺

@jodosha jodosha self-assigned this Mar 15, 2015
@jodosha jodosha added this to the v0.4.0 milestone Mar 16, 2015
@jodosha
Copy link
Member

jodosha commented Mar 16, 2015

@AlfonsoUceda I was wrong. 302 can have a body, there is no mention to suppress it. So there is no need to have this PR.

Sorry for the confusion. 😢

@jodosha jodosha closed this Mar 16, 2015
@AlfonsoUceda
Copy link
Contributor Author

ok thanks @jodosha ;)

@AlfonsoUceda AlfonsoUceda deleted the fix_redirecto_callback branch March 16, 2015 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jodosha jodosha

Labels
enhancement
Projects
None yet
Milestone
v0.4.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AlfonsoUceda @jodosha