Allow blocks when specifying Rack middleware to use

[Erol]

I am using Lotus::Controller outside of a Lotus application and ran into a problem when trying to use Rack::Auth::Basic. I was trying to configure it just like below:

Lotus::Controller.configure do
  prepare do
    use Rack::Auth::Basic, "Protected Area" do |username, password|
      username == 'admin' && password == 'password'
    end
  end
end

But I noticed that Lotus::Action::Rack::ClassMethods#use does not accept blocks when specifying middleware. I checked https://github.com/rack/rack/blob/master/lib/rack/builder.rb#L81 and Rack::Builder#use does accept blocks.

Is this intended behavior? Am I missing something?

[Erol]

Also, can't find the test for Lotus::Action::Rack::ClassMethods#use. Should I make one? 🐹

[jodosha]

@Erol You're right, it should accept a block.

Action.use

Action.use is intended for fine grained middleware configuration. For instance, if only a few resources need to use a Rack component, but not the entire app. When used, the action has a small perf penalty, but this is a good compromise because incoming requests won't go through the middleware when not needed.

Eg.

class RuntimeAction
  include Lotus::Action
  use Rack::Runtime

  def call(params)
    # ...
  end
end

class DashboardAction
  include Lotus::Action

  def call(params)
    # ...
  end
end

# GET /runtime # small perf penalty because of .use
# GET /dashboard # perf is OK, because it doesn't go through Rack::Runtime

Configuration#prepare

On the other hand, Configuration#prepare is intended for general configurations (not fine grained). Configuring .use for all the action, will add that small perf penalty to all the actions.

Solution

If you need to filter all the requests for all the actions (no fine grained approach), I suggest to mount that middleware in config.ru

[jodosha]

@Erol Please add tests here test/integration/use_test.rb, and I'll be happy to merge this. Thank you 👍

[Erol]

@jodosha Done. And thanks for the config.ru tip!

[jodosha]

@Erol Thanks for the quick implementation. Merged 👍