Lotus::Mailer::MissingDeliveryDataError buble up Mail::ArgumentError messages

[mrbongiolo]

Per issue: #38

[AlfonsoUceda]

to me the PR is ok, I'm not a big fan concat string with + but is 👍

cc @lotus/core-team

[mrbongiolo]

Will remember to use / next time :D

[runlevel5]

What do you think about rewording it so that a verb follows after it.

s/bubles/bubbles

[mrbongiolo]

It makes sense, will change it and resend :)

[mrbongiolo]

Updated it. Should be good to go xD

[jodosha]

@mrbongiolo @joneslee85 We should reconsider this code.

I'm for detailed exception messages, and showing the original reason of the error is a good practice.
But in this case, the result is misleading:

"Missing delivery data, please check " \
"'from', or 'to'. Mail::ArgumentError message => An SMTP From " \
"address is required to send a message. Set the message " \
"smtp_envelope_from, return_path, sender, or from address."

1. There isn't a Mail::ArgumentError exception
2. We don't have a smtp_envelope_from, return_path, sender.

This can generate confusion. I'm gonna revert this commit.
If we can find a less confusing solution, we can merge it again. Thank you very much.

[mrbongiolo]

Maybe we could inform just to check the config or something? The main thing is that not only a missing from or to raises those errors.

[mrbongiolo]

Since basically I just had to "check" the Original errors message and figure out that I had an error on my Mailer.config and not on the mailer itself.

[mrbongiolo]

"Missing delivery data, please check 'from', or 'to'. If those are ok please check your Lotus::Mailer config file." something like this. Sorry about the 3 messages in a row.

[jodosha]

@mrbongiolo Which was your case that left you confused? Which configuration you did it wrong?

[mrbongiolo]

Lotus::Mailer.configure do
  root 'app/notifiers/mailers/templates'

  case ENV['RACK_ENV']
  when 'production', 'staging'
    delivery_method :smtp,
                    address: 'email-smtp.us-east-1.amazonaws.com',
                    port: '587',
                    domain: 'domain.com.br',
                    user_name: ENV['AWS_SES_SMTP_KEY'],
                    password: ENV['AWS_SES_SMTP_SECRET'],
                    authentication: 'plain',
                    enable_starttls_auto: true
  when 'development', 'test'
    delivery_method :test
  end
end.load!

Here inside my config block I had a wrong value for one of the options, can't really remember which one, but when I tested to send an email the Exception message said only to check from or to. Just a complementary warning saying to checkout your config block could solve this. Since I had to check the original message and see that something else was missing. The main problem that it happened the first time I was trying Lotus::Mailer.