Nested Validations Resolved

[jacekbrozek]

Hey there!

I've tried Lotus for one of my backend services (suits perfect, btw) and I faced the problem with nested objects' validation.

I want to keep the information about the object (like validations) in separate classes (so DSL for nesting objects was not satisfying for me). Let me show you an example:

class Payment
  include Lotus::Validations

  attribute :recipient_account,  type: RecipientAccount
end

class RecipientAccount
  include Lotus::Validations

  attribute :iban, presence: true
  attribute :bic,  presence: true
end

Even if the coercion works fine for this example, there's no info about nested object validation, so I had to hack it this way:

class Payment
  include Lotus::Validations

  attribute :recipient_account,  type: RecipientAccount

  def valid?
    [ recipient_account ].all?(&:valid?) # I have more nested attributes
    # and here goes the check for the rest of primitive values
  end
end

Looks ugly, huh? (and changing the framework's default behaviour (in most cases) tells you that you shouldn't have been using framework at all)

I've resolved it in my fork (more details and examples in tests and ReadMe) and now sending the PR for review. Let me know if that might be helpful for any of Lotus' users.

P.S. This PR includes nested coercion and validations for Array[YourClass] - it was useful for me the way it is, maybe should inside a collection wrapper (didn't need that).

[khasinski]

👍

[patrykfischer]

👍

[justi]

👍

[madsheep]

🐑

[ja999]

🍻

[runlevel5]

@jac33k can you please rebase?

[jacekbrozek]

@joneslee85 done, I've noticed slight decrease of coverage, because of one (not used) method for NestedAttributes class - should I be worried or was it expected?

[runlevel5]

I would avoid using subject 'you' here if possible

[jacekbrozek]

Any particular reason? Just curious ;)

[SleeplessByte]

Validations can be nested in Hanami::Validations objects
^
statement

Also you can use validations nested in Hanami Validations object
^
action

[runlevel5]

cc @jodosha @AlfonsoUceda

[jodosha]

Fixed by #100