Merge pull request #82 from liamdawson/generalize-errors

Subclass errors from a general Lotus module error

lib/lotus/view/error.rb

@@ -0,0 +1,13 @@
+# Base view error
+#
+# This is a base error used to produce Lotus view errors.
+#
+# Allows better rescue options than simply catching `StandardError`.
+#
+# @since 0.4.4
+module Lotus
+  module View
+    class Error < ::StandardError
+    end
+  end
+end

lib/lotus/view/rendering/layout_registry.rb

@@ -1,5 +1,6 @@
 require 'lotus/view/rendering/null_template'
 require 'lotus/view/rendering/templates_finder'
+require 'lotus/view/error'
 
 module Lotus
   module View
@@ -9,7 +10,7 @@ module Rendering
       # This is raised at the runtime when Lotus::Layout cannot find it's template.
       #
       # @since 0.3.0
-      class MissingTemplateLayoutError < ::StandardError
+      class MissingTemplateLayoutError < Lotus::View::Error
         def initialize(template)
           super("Can't find layout template '#{ template }'")
         end

test/layout_test.rb

@@ -8,7 +8,7 @@
     end
   end
 
-  it "raise error if template isn't found" do
+  it "raise subclassed error if template isn't found" do
     Lotus::View.unload!
 
     class MissingLayout
@@ -19,6 +19,7 @@ class MissingLayout
       Lotus::View.load!
     }.must_raise(Lotus::View::Rendering::MissingTemplateLayoutError)
     error.message.must_include "Can't find layout template 'MissingLayout'"
+    error.class.ancestors.must_include Lotus::View::Error
   end
 
   it 'concrete methods are available in layout template' do