Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment in registry.rb#48 notes that there should only be one registr… #90

Closed
wants to merge 1 commit into from
Closed

Conversation

pascalbetz
Copy link

#89

…y per

view superclass. Test shows that this is not the case.
@runlevel5 runlevel5 added this to the v0.5.0 milestone Jan 9, 2016
@runlevel5 runlevel5 self-assigned this Jan 9, 2016
@runlevel5
Copy link
Member

please fix the build

@pascalbetz
Copy link
Author

@joneslee85 this is a test to show the problem. I would need some input on how to fix it (make sure there is only one registry per view hierarchy or lifting this restriction and having one registry per view). Probably best to discuss in the issue.

@runlevel5
Copy link
Member

@pascalbetz sure, bring it to the chat room please

@jodosha jodosha removed this from the v0.5.0 milestone Jan 12, 2016
@jodosha jodosha added this to the next milestone Jan 29, 2016
@jodosha jodosha assigned jodosha and runlevel5 and unassigned runlevel5 and jodosha Jan 29, 2016
@jodosha
Copy link
Member

jodosha commented Jan 29, 2016

@pascalbetz Hey, now I understand the problem. As I mentioned before, if there is a way to change the internals of this framework, but without changing the existing behaviors, I'm fine with all the solutions.

Do you still want to take care of this?

@pascalbetz
Copy link
Author

@jodosha i can look into, yes.
After our previous discussions i'm not sure how much of an issue it is because it was never meant to subclass and keep the format.

@jodosha
Copy link
Member

jodosha commented Feb 4, 2016

@pascalbetz Closing this because not high priority.

@jodosha jodosha closed this Feb 4, 2016
timriley added a commit that referenced this pull request Mar 15, 2020
Introduce customizable scope objects
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants