Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move WorldImpl under detail namespace #481

Closed
louis-langholtz opened this issue Apr 18, 2023 · 1 comment
Closed

Move WorldImpl under detail namespace #481

louis-langholtz opened this issue Apr 18, 2023 · 1 comment
Assignees
@louis-langholtz
Labels
Enhancement For suggestions or changes that enhance any part of the project and isn't a bug. Library For issues that effect the library and aren't specific to any particular application.
Projects
Reduce Namespace Pollution
Milestone
2.0 Release

Comments

@louis-langholtz
Copy link
Owner

Expected/Desired Behavior or Experience:

The implementation detail that is named WorldImpl resides in playrho::d2::detail.

Actual Behavior:

It's at playrho::d2::WorldImpl.
@louis-langholtz louis-langholtz added Enhancement For suggestions or changes that enhance any part of the project and isn't a bug. Library For issues that effect the library and aren't specific to any particular application. labels Apr 18, 2023
@louis-langholtz louis-langholtz added this to the 2.0 Release milestone Apr 18, 2023
@louis-langholtz louis-langholtz self-assigned this Apr 18, 2023
@louis-langholtz louis-langholtz added this to To do in Reduce Namespace Pollution via automation Apr 18, 2023
@louis-langholtz
Copy link
Owner Author

louis-langholtz commented Aug 25, 2023 •
edited

It's an implementation detail of sorts sure. But it's also a World conforming type. Like a World concepts fulfilling class. Maybe a preferable first step is to rename WorldImpl to something more suggestive of this. Like AabbTreeWorld.

  • Rename WorldImpl to something more implementation specific.

@louis-langholtz louis-langholtz closed this as not planned Won't fix, can't repro, duplicate, stale Oct 10, 2023
Reduce Namespace Pollution automation moved this from To do to Done Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@louis-langholtz louis-langholtz

Labels
Enhancement For suggestions or changes that enhance any part of the project and isn't a bug. Library For issues that effect the library and aren't specific to any particular application.
Projects
Reduce Namespace Pollution
Done
Milestone
2.0 Release
Development

No branches or pull requests
1 participant
@louis-langholtz