-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Int or Word16 over Integer (KnownNat) #8
Comments
Thanks for the tip! I'll definitely look into this. |
@reactormonk, what do you think of my changes in e5a3759#diff-cdf46e7019f0efa12eb0f0a041231ee1R22? I'm using overlapping instances in order to reuse the GHC.TypeLit Nat, instead of defining my own. It's a less intrusive change in my library since I use the type operator '+'. If you are happy with this change, I'll upload a v5.0.0.0 into Hackage |
You're too fast. Thanks! |
Apparently GHC is terrible at optimizing Integers, so switching to e.g. https://github.com/VinylRecords/Vinyl/blob/a5ffd10fbc747c5366ae9806e61bf45f78c3eb33/Data/Vinyl/TypeLevel.hs#L24 might be beneficial.
The text was updated successfully, but these errors were encountered: