Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work with Android project using com.google.gms:google-services:3.2.1 #2

Closed
vagrantrobbie opened this issue Apr 5, 2018 · 3 comments
Assignees

Comments

@vagrantrobbie
Copy link

I am using the Firebase services but these all seem to use v11.8.0 and I keep getting a "merge dex" Exception. I know I am a bad person for hardcoding your implementation to use
implementation "com.google.android.gms:play-services-location:11.8.0"

Is there a better way to do handle this situation?

@lukaspili
Copy link
Contributor

Thanks for the report, I will check today what's the best way to solve it.

@lukaspili lukaspili self-assigned this Apr 5, 2018
@lukaspili lukaspili added the bug Something isn't working label Apr 5, 2018
@vagrantrobbie
Copy link
Author

This is a much safer fix for now.

I have removed my hardcoded version from your plugin and added to my android/app/build.gradle, just before dependencies:

configurations.all {
resolutionStrategy {
force 'com.google.android.gms:play-services-location:11.8.0'
}
}

dependencies {
...

@lukaspili
Copy link
Contributor

Indeed, I would even suggest:

configurations.all {
    resolutionStrategy {
        eachDependency { details ->
            if (details.requested.group == 'com.google.android.gms' ||
                    details.requested.group == 'com.google.firebase') {
                details.useVersion "your version"
            }
        }
    }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants