Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatting and Add formatting to CI workflow #291

Closed
bhavik001 opened this issue Nov 24, 2023 · 3 comments
Closed

Formatting and Add formatting to CI workflow #291

bhavik001 opened this issue Nov 24, 2023 · 3 comments
Assignees

Comments

@bhavik001
Copy link
Contributor

Hey @lovasoa !
I want to add Formatting to the project and in the CI workflow can you assign me this issue? I am interested in working on it.

@bhavik001
Copy link
Contributor Author

Hey @lovasoa !
I have added new pull request as you mention earlier. Can you please review and merge the pull request. Also can you assign me to this issue as I have to show it to my professor for my college work. Let me know if I have to make any changes.

@lovasoa
Copy link
Owner

lovasoa commented Nov 24, 2023

Hello! You don't need to mention@lovasoa in every message, I get the notifications anyway :) I'll look at your new PR when I can, but keep in mind that everyone here is a volunteer. A reminder after some time of inactivity is fine, but you cannot expect volunteers to always answer answer your questions immediately.

Also, if your goal is to get something merged quickly, you should probably try something with a smaller diff, and that more clearly benefits the project.

@bhavik001
Copy link
Contributor Author

bhavik001 commented Nov 24, 2023

Okay. And also whenever you get time can you please assign me this issue?

Sorry for the disturbance I have created to you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants