Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Shader for OpenGL ES 2.0 feature set #11

Closed
s-ol opened this issue Feb 21, 2016 · 12 comments
Closed

Fix Shader for OpenGL ES 2.0 feature set #11

s-ol opened this issue Feb 21, 2016 · 12 comments

Comments

@s-ol
Copy link
Member

s-ol commented Feb 21, 2016

  • fix use of int/float types
  • don't rely in smoothstep

This is what currently causes the issues with the gh-pages /love.js builds.

@rm-code
Copy link
Contributor

rm-code commented Feb 21, 2016

I'll see what I can do. Wanted to get back into GLSL coding anyway.

@rm-code
Copy link
Contributor

rm-code commented Feb 21, 2016

Welp ... @TannerRogalsky was faster :D

@JanWerder
Copy link
Member

I still seems to crash

@rm-code
Copy link
Contributor

rm-code commented Feb 21, 2016

Yup, same here.

@TannerRogalsky
Copy link
Member

@JanWerder @rm-code Please read through that PR. There is another issue.

@TannerRogalsky
Copy link
Member

I'm going to provide a 'compatibility' build going forward to avoid issues like this. Performance and file size take a hit but it should be easier to work with. https://github.com/TannerRogalsky/love.js/tree/master/release-compatibility

@s-ol
Copy link
Member Author

s-ol commented Feb 21, 2016

Can someone verify that love2d-community.github.io/splashes does now work with the compat love.js?

@TannerRogalsky
Copy link
Member

@S0lll0s I'm getting the following error:

Error: [string "boot.lua"]:432: No code to run
love.js:1 Your game might be packaged incorrectly
love.js:1 Make sure main.lua is at the top level of the zip
love.js:1 stack traceback:
love.js:1   (tail call): ?
love.js:1   [C]: in function 'error'
love.js:1   [string "boot.lua"]:432: in function <[string "boot.lua"]:274>
love.js:1   [C]: in function 'xpcall'

@s-ol
Copy link
Member Author

s-ol commented Feb 21, 2016

hm, for some reason love.js completely wrecks my browser. Can't even debug this situation right now until I get back home in 2-3 weeks :/

@slime73
Copy link
Member

slime73 commented Mar 2, 2016

don't rely in smoothstep

smoothstep works fine in OpenGL ES 2's shading language.

@TannerRogalsky
Copy link
Member

@slime73 #12 (comment) :D :D

@s-ol
Copy link
Member Author

s-ol commented Mar 3, 2016

So think this is done then?

@s-ol s-ol closed this as completed Mar 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants