Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Letters display as boxes #52

Closed
slime73 opened this issue Aug 11, 2010 · 11 comments
Closed

Letters display as boxes #52

slime73 opened this issue Aug 11, 2010 · 11 comments
Labels
bug Something isn't working

Comments

@slime73
Copy link
Member

slime73 commented Aug 11, 2010

Original report by Robin Wellner (Bitbucket: gvx, GitHub: gvx).


In love-hg, latest revision, letters are displayed as boxes, with the same proportions as the letters would be (some sort of bounding boxes).

This happens with every .love, and even when passing a wrongly-packages .love.

For some reason, with the font Space uses, the u and n display normally, but all the other characters are boxes.

@slime73
Copy link
Member Author

slime73 commented Aug 11, 2010

Original comment by Bart van Strien (Bitbucket: bartbes, GitHub: bartbes).


Assigning this to bill, who worked on fonts for 0.7.0.

@slime73
Copy link
Member Author

slime73 commented Aug 12, 2010

Original comment by Bill Meltsner (Bitbucket: bmelts, GitHub: bmelts).


I'd bet you twenty bucks that this is yet another power-of-2 issue, something that I'm really getting sick of. (Dear robin-gvx: your graphics card sucks and I hate it.)

I know we don't pad things by default anymore, but we should probably consider doing that for fonts. Thoughts, bartbes?

@slime73
Copy link
Member Author

slime73 commented Aug 12, 2010

Original comment by Bart van Strien (Bitbucket: bartbes, GitHub: bartbes).


Ehm, why would you ever not want to pad fonts?

@slime73
Copy link
Member Author

slime73 commented Aug 13, 2010

Original comment by Robin Wellner (Bitbucket: gvx, GitHub: gvx).


I hate my graphics card (and drivers) too, but yeah, why not do them like they were done in 0.6?

@slime73
Copy link
Member Author

slime73 commented Aug 19, 2010

Original comment by Bill Meltsner (Bitbucket: bmelts, GitHub: bmelts).


Okay, this is nominally fixed in <<changeset 079397ac976b>> but I don't have a computer to test it on. It'd be awesome if someone without non-power-of-2 texture support could test out the latest revision and see if fonts show up for them.

@slime73
Copy link
Member Author

slime73 commented Aug 25, 2010

Original comment by Andrzej Giniewicz (Bitbucket: giniu, GitHub: giniu).


It seems strange, but with r355 and even simple Hello World from wiki, so:

#!lua

function love.draw()
    love.graphics.print('Hello World!', 400, 300)
end

I'm getting

Program received signal SIGSEGV, Segmentation fault.
0x00007ffff55b8359 in free () from /lib/libc.so.6
(gdb) bt
#0  0x00007ffff55b8359 in free () from /lib/libc.so.6
#1  0x0000000000411f4a in love::font::GlyphData::pad() ()
#2  0x0000000000412741 in love::font::freetype::TrueTypeRasterizer::getGlyphData(unsigned short) const ()
#3  0x0000000000413c67 in love::font::FontData::FontData(love::font::Rasterizer*) ()
#4  0x0000000000412fc4 in love::font::freetype::Font::newFontData(love::font::Rasterizer*) ()
#5  0x000000000041295e in love::font::freetype::w_newFontData(lua_State*) ()
#6  0x00007ffff6aaa79d in ?? () from /usr/lib/liblua.so
#7  0x00007ffff6aaac24 in ?? () from /usr/lib/liblua.so
#8  0x00007ffff6aa67b6 in lua_call () from /usr/lib/liblua.so
#9  0x0000000000410f72 in love::luax_convobj(lua_State*, int, char const*, char const*) ()
#10 0x0000000000450337 in love::graphics::opengl::w_setFont1(lua_State*) ()
#11 0x00007ffff6aaa79d in ?? () from /usr/lib/liblua.so
#12 0x00007ffff6ab54cc in ?? () from /usr/lib/liblua.so
#13 0x00007ffff6aaac6d in ?? () from /usr/lib/liblua.so
#14 0x00007ffff6aa9ef7 in ?? () from /usr/lib/liblua.so
#15 0x00007ffff6aaae32 in ?? () from /usr/lib/liblua.so
#16 0x00007ffff6aa6851 in lua_pcall () from /usr/lib/liblua.so
#17 0x00007ffff6ab7bec in ?? () from /usr/lib/liblua.so
#18 0x00007ffff6aaa79d in ?? () from /usr/lib/liblua.so
#19 0x00007ffff6ab55e1 in ?? () from /usr/lib/liblua.so
#20 0x00007ffff6aaac6d in ?? () from /usr/lib/liblua.so
#21 0x00007ffff6aa67b6 in lua_call () from /usr/lib/liblua.so
#22 0x0000000000489a44 in main ()

I don't know if this is exactly after only r355 or later few speed-up revisions (wasn't checking right after), though it seems related so I decided to post it here :)

@slime73
Copy link
Member Author

slime73 commented Aug 25, 2010

Original comment by Bill Meltsner (Bitbucket: bmelts, GitHub: bmelts).


I would wager that's an issue with me being dumb and using the wrong delete in pad() (and perhaps with Mac OS X being somewhat... generous with what it allows, code-wise). Try the latest revision?

@slime73
Copy link
Member Author

slime73 commented Aug 26, 2010

Original comment by Linus (Bitbucket: thelinx, GitHub: thelinx).


Well, it doesn't segfault anymore. However, like I mentioned in IRC, I'm not sure if it actually //works//...

@slime73
Copy link
Member Author

slime73 commented Aug 26, 2010

Original comment by Robin Wellner (Bitbucket: gvx, GitHub: gvx).


I get a segfault too, when giving love-hg a wrongly-packaged directory.

@slime73
Copy link
Member Author

slime73 commented Aug 26, 2010

Original comment by Andrzej Giniewicz (Bitbucket: giniu, GitHub: giniu).


current tip works for me, no segfault, though I cannot tell about original issue as it always worked for me

@slime73
Copy link
Member Author

slime73 commented Aug 26, 2010

Original comment by Bart van Strien (Bitbucket: bartbes, GitHub: bartbes).


Oh I fixed it (confirmed by robin in IRC), of course our friend here assumed too much...

@slime73 slime73 closed this as completed Aug 26, 2010
@slime73 slime73 added major bug Something isn't working labels Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant