Build Errors

[JedWatson]

Hi @lovell,

I'm seeing build errors with the latest version of limax and its dependencies, and was hoping you could help me get them resolved.

The errors seem to be in nodejieba, which is a dependency of the pinyin package implemented in cdb8d59

Full debug output:

> nodejieba@1.0.3 install /Users/Jed/Development/packages/keystone/node_modules/keystone-utils/node_modules/limax/node_modules/pinyin/node_modules/nodejieba
> node-gyp rebuild

  CXX(target) Release/obj.target/nodejieba/lib/index.o
In file included from ../lib/index.cpp:1:
In file included from ../lib/nodejieba.h:4:
../lib/utils.h:17:11: error: use of undeclared identifier 'NanIntern'
  array = NanIntern::Factory<v8::Array>::New(ov.size());
          ^
../lib/utils.h:17:39: error: expected '(' for function-style cast or type construction
  array = NanIntern::Factory<v8::Array>::New(ov.size());
                             ~~~~~~~~~^
../lib/utils.h:17:42: error: no member named 'New' in the global namespace
  array = NanIntern::Factory<v8::Array>::New(ov.size());
                                       ~~^
../lib/utils.h:19:21: error: use of undeclared identifier 'NanIntern'
      array->Set(i, NanIntern::Factory<v8::String>::New(ov[i].c_str()));
                    ^
../lib/utils.h:19:50: error: expected '(' for function-style cast or type construction
      array->Set(i, NanIntern::Factory<v8::String>::New(ov[i].c_str()));
                                       ~~~~~~~~~~^
../lib/utils.h:19:53: error: no member named 'New' in the global namespace
      array->Set(i, NanIntern::Factory<v8::String>::New(ov[i].c_str()));
                                                  ~~^
../lib/utils.h:24:11: error: use of undeclared identifier 'NanIntern'
  array = NanIntern::Factory<v8::Array>::New(ov.size());
          ^
../lib/utils.h:24:39: error: expected '(' for function-style cast or type construction
  array = NanIntern::Factory<v8::Array>::New(ov.size());
                             ~~~~~~~~~^
../lib/utils.h:24:42: error: no member named 'New' in the global namespace
  array = NanIntern::Factory<v8::Array>::New(ov.size());
                                       ~~^
../lib/utils.h:30:19: error: use of undeclared identifier 'NanIntern'
    array->Set(i, NanIntern::Factory<v8::String>::New(ss.str().c_str()));
                  ^
../lib/utils.h:30:48: error: expected '(' for function-style cast or type construction
    array->Set(i, NanIntern::Factory<v8::String>::New(ss.str().c_str()));
                                     ~~~~~~~~~~^
../lib/utils.h:30:51: error: no member named 'New' in the global namespace
    array->Set(i, NanIntern::Factory<v8::String>::New(ss.str().c_str()));
                                                ~~^
../lib/utils.h:35:11: error: use of undeclared identifier 'NanIntern'
  array = NanIntern::Factory<v8::Array>::New(ov.size());
          ^
../lib/utils.h:35:39: error: expected '(' for function-style cast or type construction
  array = NanIntern::Factory<v8::Array>::New(ov.size());
                             ~~~~~~~~~^
../lib/utils.h:35:42: error: no member named 'New' in the global namespace
  array = NanIntern::Factory<v8::Array>::New(ov.size());
                                       ~~^
../lib/utils.h:41:19: error: use of undeclared identifier 'NanIntern'
    array->Set(i, NanIntern::Factory<v8::String>::New(ss.str().c_str()));
                  ^
../lib/utils.h:41:48: error: expected '(' for function-style cast or type construction
    array->Set(i, NanIntern::Factory<v8::String>::New(ss.str().c_str()));
                                     ~~~~~~~~~~^
../lib/utils.h:41:51: error: no member named 'New' in the global namespace
    array->Set(i, NanIntern::Factory<v8::String>::New(ss.str().c_str()));
                                                ~~^
18 errors generated.
make: *** [Release/obj.target/nodejieba/lib/index.o] Error 1

[lovell]

Thanks Jed, looks like pinyin needs to be updated to use a more recent version of nodejieba to pick up a more recent version of nan. Leave it with me.

🐢
🐢
🐢

[mark-bradshaw]

Pinyin is updated as of now. This issue is fixed.

[lovell]

Thanks @mark-bradshaw!