Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect Edge browser and uncomment uninstall url #23

Open
loveshdongre opened this issue Apr 7, 2023 · 3 comments
Open

Detect Edge browser and uncomment uninstall url #23

loveshdongre opened this issue Apr 7, 2023 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@loveshdongre
Copy link
Owner

In background.js file we have isEdge variable, we need to update this variable appropriately and uncomment the below lines

// else if(isEdge) {
    // browser.runtime.setUninstallURL("https://microsoftedge.microsoft.com/addons/detail/leetcode-enhancer/dgddijgkneackjhmijacbopefpladfia") // edge feedback url
// }
@loveshdongre loveshdongre added good first issue Good for newcomers enhancement New feature or request labels Apr 7, 2023
@Shehu-Yakubu
Copy link

I can take this, assign it to me.

@loveshdongre
Copy link
Owner Author

Clearing the assignee since it's a small change, will directly accept the pull request whosoever creates it.

@loveshdongre
Copy link
Owner Author

Can you also uncomment the lines mentioned in this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@loveshdongre @Shehu-Yakubu