Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is Goka still support Confluent-Kafka client? #349

Closed
chin8628 opened this issue Sep 22, 2021 · 4 comments
Closed

Is Goka still support Confluent-Kafka client? #349

chin8628 opened this issue Sep 22, 2021 · 4 comments

Comments

@chin8628
Copy link
Contributor

Hi.

I might misunderstand. However, I read through the repo and found that a GitHub wiki mentions integration with Confluent-Kafka.

But I've checked PRs and I understand that Goka has migrated to Sarama Client 100% and removed all code of Confluent-Kafka client already.

So, I just want to make sure about it since I can found the wiki about the Confluent-Kafka client on this URL.

https://github.com/lovoo/goka/wiki/Tips#using-confluent-kafka-client

@chin8628
Copy link
Contributor Author

chin8628 commented Sep 22, 2021

Oh found it. Confluent-Kafka part is removed. #260

I will appreciate it if you update the wiki.

@frairon
Copy link
Contributor

frairon commented Sep 29, 2021

Hey @chin8628,
true we removed it, but it's still in the docs probably.
They're are still a bit messy, but one day we'll have the time to fix them :).
Thanks for your contribution!

@intel352
Copy link

In 2023, wiki still claims Confluent's go library can replace sarama: https://github.com/lovoo/goka/wiki/Introduction

but that can be easily replaced with Confluent's go library.

@frairon
Copy link
Contributor

frairon commented Feb 13, 2023

Good point, just removed the note in the wiki. It's quite outdated and we are still working on an improved documentation. But who knows when that's going to be finished 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants