Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out enabling/disabling modules without restarting manually #7

Closed
astrobokonon opened this issue Jul 8, 2019 · 5 comments
Closed

Comments

@astrobokonon
Copy link
Member

Ideally, this would be fairly transparent and all happen thru the broker. BUT, that means that whomever/whichever client issues the commands needs to know about the active modules that Mr. Freeze has, either because they're all hardcoded or because they're advertised. If it's the former, I wonder just why I have a configuration file in the first place. Seems like it should be the latter - Mr. Freeze/Nora should advertise their active modules once every XX seconds and anyone can listen/discover them.

Should I allow arbitrary injection of whole new modules? Seems possible, but might not be a good idea. The command-issuer necessarily must have some knowledge of what the format should be, but the more I think about this the more I realize that having a hardcoded configuration file is a bit of a breaking

@astrobokonon astrobokonon self-assigned this Jul 8, 2019
@astrobokonon astrobokonon added this to To do in MrFreeze via automation Jul 8, 2019
@astrobokonon
Copy link
Member Author

This is all especially important during these warm up/cool downs/removals. It'd be a big PITA if I had to change the config manually each time, this seems like it should be a major component of the user interface.

@astrobokonon
Copy link
Member Author

First task: reorganize the parsed configuration to be per-instrument rather than per-device. Having things per-instrument will be easier/faster for logging as well.

@astrobokonon
Copy link
Member Author

This also means determining the exact structure of the command packet. There's a lot wrapped up in this single issue.

@astrobokonon
Copy link
Member Author

astrobokonon commented Jul 10, 2019

RE: the above, see #8

@astrobokonon
Copy link
Member Author

I think this issue is good to close, since it's really wrapped up in the other issue. Closing.

MrFreeze automation moved this from To do to Done Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
MrFreeze
  
Done
Development

No branches or pull requests

1 participant