Adding hover on pins #110
Merged
Adding hover on pins #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
Up (to remove stale) |
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
Removing stale |
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
lpongetti
reviewed
Aug 11, 2022
|
pls fix conflicts |
|
Conflicts has been resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I'm working on a web project that uses flutter_map_marker_cluster and adding the hovers on markers using clusters is an important feature of my project.
If buildPopupOnHover is set to true, a MouseRegion will encapsulates the marker.builder (within the GestureDetector) and the popup will be built when the marker is hovered. When tapping a Marker, only the onMarkerTap method will be called.
I also added two methods : onMarkerHoverEnter and onMarkerHoverExit which follow the spirit of onMarkerTap : they're called respectively on hover enter and on hover exit.
Finally, I added a timer before the popup is shown, this timer is set to 300 ms by default.
I hope we can do something for the hovering feature to be added as it can be very useful for web projetcs.
Thanks for reading!