Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent exploding behaviour within clusters and more #123

Closed
aytunch opened this issue Jul 6, 2022 · 10 comments
Closed

Inconsistent exploding behaviour within clusters and more #123

aytunch opened this issue Jul 6, 2022 · 10 comments

Comments

@aytunch
Copy link
Contributor

aytunch commented Jul 6, 2022

The two clusters you see in the video each have 2 Markers at same lat long.
When I press the top left cluster, it centers and then "explodes"
But when I press the bottom right cluster, it just centers. For it to show the contents, I need to press one more time.

Sorry that this issue turned out to be an issue cluster. pun intended :D I think it can help other users too.

I have a couple of questions:

  1. How can I make it such that users don't need to press it a second time to see the singular markers? (just like top left cluster)
  2. How can I un-explode the singular markers back to the cluster state, once the user presses on an empty space in the map. I see there is a similar API for popUpController.hideAll but I guess popups are something different than the markers. I handle the onPressed of the markers within the widgets.
  3. When we explode the cluster, cluster icon's opacity is decreased and stays at the same place. When user presses it, we un-explode the cluster back. How can we customize the appearance of the exploded state of the cluster widget? let's say I want to put there a more explanatory icon like "close - X".
  4. Is there a way to catch cluster onPressed events and decide if we want to explode and unexplode markers? Let's say maybe I want to keep the contents of several clusters in an expanded state.
  5. Before using this plugin, I was able to animate the show/hide states of markers in the MarkerLayerOptions.markers. Now that I carried those markers under MarkerClusterLayerOptions.markers, the AnimatedOpacity don't work anymore. I guess there is a problem with the state object somewhere. (I don't use children property. instead put all my markers under layers)
cluster.mov

On another note, you can see that the exploded cluster disappears from the right edge of the screen. I was struggling with this issue on the parent flutter_map and have an open PR fleaflet/flutter_map#1291
I was using my own branch but unfortunately I am forced to use the main flutter_map along with this cluster plugin (even if I branched out of flutter_map: ^1.1.1)

  • Is there a way to use and test out cluster plugin with my branch without pub get dependency errors?
  • And would my PR fix disappearing clusters and help out this plugin somehow? In the code I could not see where the Rect size was set for the spider rect.
spider_disappear.mov
@github-actions
Copy link

github-actions bot commented Aug 6, 2022

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Aug 6, 2022
@github-actions
Copy link

This issue was closed because it has been stalled for 5 days with no activity.

@aytunch
Copy link
Contributor Author

aytunch commented Aug 13, 2022

@lpongetti this issue is still present in our app. Can we keep the issue open please?

@lpongetti lpongetti reopened this Aug 13, 2022
@lpongetti
Copy link
Owner

can you pls prepare a sample code to do some tests?

@github-actions github-actions bot removed the Stale label Aug 14, 2022
@lpongetti
Copy link
Owner

fixed with version 0.5.4

@lpongetti
Copy link
Owner

fixed with version 0.5.4

@aytunch
Copy link
Contributor Author

aytunch commented Aug 14, 2022

@lpongetti thanks. I will try it as soon as 0.5.4 is live on pub dev. I still see 0.5.3

@lpongetti
Copy link
Owner

yes, one moment.. now my connection is very poor :)

@aytunch
Copy link
Contributor Author

aytunch commented Aug 14, 2022

Works perfect and as intended. Thanks @lpongetti

@basnetjiten
Copy link

@aytunch How did you resolved the issues of on click cluster it first centers and need to click it second time to show the clusters. Could you please elaborate a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants