Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added rotate option #73

Merged
merged 1 commit into from May 27, 2021
Merged

Added rotate option #73

merged 1 commit into from May 27, 2021

Conversation

amereii
Copy link
Contributor

@amereii amereii commented Apr 28, 2021

Similar to fleaflet/flutter_map#864 I added rotate option to flutter_map_marker_cluster
We must wait for rorystephenson/flutter_map_marker_popup#17 to be merged to remove dependency_overrides

@amereii
Copy link
Contributor Author

amereii commented May 31, 2021

@lpongetti I wonder how the merging PR might have been done? My changes is not in master branch and the latest release
Can you check it?

@@ -17,6 +17,12 @@ dependencies:
latlong: ^0.6.1
flutter_map_marker_popup: ^0.2.0

dependency_overrides:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why dependency_overrides?

Copy link
Contributor Author

@amereii amereii Jun 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I told

We must wait for rorystephenson/flutter_map_marker_popup#17 to be merged to remove dependency_overrides

As I was too busy to fix it completely it's not merged but thanks to @rorystephenson now you can remove dependency_overrides and use flutter_map_marker_popup: ^0.3.0

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls fix it and reopen

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lpongetti I tried to upgrade to flutter_map_marker_popup: ^0.3.0 but unfortunately MarkerPopup was removed and currently I'm too busy to fix it

@Y0ngg4n
Copy link

Y0ngg4n commented Oct 4, 2021

Does rotate work now? I don´t find the option for it?

@rorystephenson
Copy link
Contributor

Does rotate work now? I don´t find the option for it?

You should enable rotation in the flutter_map options.

@Y0ngg4n
Copy link

Y0ngg4n commented Oct 5, 2021

@rorystephenson I added it to the Marker or what option do you mean?

@rorystephenson
Copy link
Contributor

@rorystephenson I added it to the Marker or what option do you mean?

Rotation is a map-level option. If it is enabled in the options of the FlutterMap widget then I believe it should just work. If that's not the case for you then please share a minimal example where rotation doesn't work.

@Y0ngg4n
Copy link

Y0ngg4n commented Oct 15, 2021

@rorystephenson i really don´t now how that works:
image
Rotation is a double in MapOptions. but there is no rotate boolean to counter rotate the markers on rotation.
I dont know what option do you mean.

@rorystephenson
Copy link
Contributor

@rorystephenson i really don´t now how that works: image Rotation is a double in MapOptions. but there is no rotate boolean to counter rotate the markers on rotation. I dont know what option do you mean.

This is not the right option. The option for enabling/disabling rotation (as well as various other interaction options) is interactiveFlags which should default to 'all' unless you have set it otherwise. Can you confirm whether or not your map is rotatable?

@Y0ngg4n
Copy link

Y0ngg4n commented Oct 18, 2021

@rorystephenson Ah thanks. My map is rotatable but the Cluster Markers are not counter rotating.

@rorystephenson
Copy link
Contributor

@rorystephenson Ah thanks. My map is rotatable but the Cluster Markers are not counter rotating.

Ah OK good point I just tested this and I can see what you mean, neither the cluster markers or the markers themselves are counter rotated to the map rotation. I have rotation disabled in my app so I never noticed.

It's probably worth a new issue to fix this.

@Y0ngg4n Y0ngg4n mentioned this pull request Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants