Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Production vs Environment #10

Closed
RuiAAPeres opened this issue Nov 2, 2014 · 0 comments
Closed

Production vs Environment #10

RuiAAPeres opened this issue Nov 2, 2014 · 0 comments

Comments

@RuiAAPeres
Copy link
Contributor

The API is a bit awkward to be used:

+ (Liquid *)sharedInstanceWithToken:(NSString *)apiToken;
+ (Liquid *)sharedInstanceWithToken:(NSString *)apiToken development:(BOOL)development;

Wouldn't it be preferable to do something along the lines of:

+ (Liquid *)sharedInstanceWithToken:(NSString *)apiToken environment:(LQEnvironment)environment;

The LQEnvironment would be an enum, where the Development and Production could be stored.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RuiAAPeres @miguelcma