Minor change on Liquid Demo app interface #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the anonymous user identifier into its own button, allowing one to identify an anonymous user multiple times successively. Also reuse the last segmented control discrete button to add a new identified user. This should allow more freedom on switching users and will allow us to replicate some bugs caused by edge case uses of the identify user with anonymous. Signed-off-by: João Soares <jsoaresgeral@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the anonymous user identifier into its own button, allowing one to
identify an anonymous user multiple times successively.
Also reuse the last segmented control discrete button to add a new
identified user.
This should allow more freedom on switching users and will allow us to
replicate some bugs caused by edge case uses of the identify user with
anonymous.