-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Possible memory leak #87
Comments
hey @tigger9flow ! thanks for reporting that. In the browser, Here's some code to help: <script>
// Delete native fetch api to force the polyfill installation
delete window.fetch
delete window.Request
delete window.Response
delete window.Headers
</script>
<script src="https://unpkg.com/whatwg-fetch@3.5.0/dist/fetch.umd.js"></script> If it does, please report the issue on https://github.com/github/fetch/issues. Otherwise, please let me know so I can take a look. |
Hey, @lquixada! You're totally right, it's reproduced in |
no worries @tigger9flow ! happy to help! thanks for reporting the issue on |
Seems like
cross-fetch
has a memory leak. Tested in the browser (Google Chrome, 88). The issue is reproduced by simple script (ignore CORS error, it behaves the same when request is resolved) which fires requests in interval:After profiling around 1 minute, we can see that event listeners are constantly growing:
While they are fine with native
fetch
:The text was updated successfully, but these errors were encountered: