Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appup file generated by rebar3_appup_generate contains all files if only the compile options change #66

Closed
tothlac opened this issue May 19, 2022 · 2 comments

Comments

@tothlac
Copy link

tothlac commented May 19, 2022

The plugin uses beam_lib:cmp_dirs/2 to get the list of changed files. It works well if the beam files in the two releases
were compiled using the same erl_opts flag. Unfortunately for instance if I add option deterministic to erl_opts the plugin thinks
all files were changed.

Unfortunately, we have experienced this problem between two releases. Only two files have been changed but hundreds of files were added to the appup file.

Using a modified version of beam_lib:cmp_dirs which filters out some attributes from the abstract code should be able to fix this problem.

@tothlac
Copy link
Author

tothlac commented May 19, 2022

Check this pull request. I've tried it and looks like it fixes the issue. Maybe it should be tested by changing different compile options as well.
#67

@lrascao
Copy link
Owner

lrascao commented Jun 26, 2022

closing via #67
thanks!

@lrascao lrascao closed this as completed Jun 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants